GoogleContainerTools / GoogleContainerTools/skaffold

Bug/feature req: Show errors from Lifecycle hook when it fails

Open
#7,019 3 comments 0 reactions 0 assignees View on GitHub
area/status-check help wanted kind/enhancement priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior
If a lifecycle hook fails, and the pod fails to start up, its "invisible" to the skaffold user, I expected it to log events from the lifecycle hooks.

### Actual behavior
Waiting, and then terminating without any obvious reason to why

### Information

- Skaffold version: 1.29.0
- Operating system: Fedora 32
- Installed via: gcloud components / package manager

### Steps to reproduce the behavior
Event logs fetch via Lens:
```
Exec lifecycle hook ([php bin/console cache:warmup -n]) for Container "eportal" in Pod "eportal-6cc67c6456-sgb9z_morten(b3217653-88da-4970-955d-8012e1aed6d6)" failed - error: command 'php bin/console cache:warmup -n' exited with 1: In DefinitionErrorExceptionPass.php line 54: Cannot autowire service "App\Controller\ApiOperations\Group\GetAvailableGro upMeetings": argument "$request" of method "__construct()" references class "Symfony\Component\HttpFoundation\Request" but no such service exists. , message: "\nIn DefinitionErrorExceptionPass.php line 54:\n \n Cannot autowire service \"App\\Controller\\ApiOperations\\Group\\GetAvailableGro \n upMeetings\": argument \"$request\" of method \"__construct()\" references class \n \"Symfony\\Component\\HttpFoundation\\Request\" but no such service exists. \n \n\n"
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.