GoogleContainerTools / GoogleContainerTools/skaffold

Support FederatedDeployment manifest type

Open
#6,968 1 comment 0 reactions 0 assignees View on GitHub
kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

When application is deployed to federated clusters (with help of [kubefed](https://github.com/kubernetes-sigs/kubefed)) - deployment manifest should be wrapped with `FederatedDeployments`. Currently, skaffold is not aware about such deployment type.

### Expected behavior
Skaffold should update images for `FederatedDeployments `in the same way as it does with `Deployments` when using kustomize/kubectl deployment menthods

### Actual behavior
Skaffold doesn't change image tag for the following deployment after `skaffold run` as not aware about it:
```
apiVersion: types.kubefed.io/v1beta1
kind: FederatedDeployment
spec:
template:
spec:
template:
spec:
containers:
image: xxx
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.