GoogleContainerTools / GoogleContainerTools/skaffold
Status check should monitor CRDs to ensure they are established
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
Our status checks should [wait for CRDs to be established](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/). This should be checking that the `status.conditions[type="Established"].status == "True"`. Valid condition names are `Established`, `NamesAccepted`, and `Terminating` (via `kubectl explain crd.status.conditions.type`).
```
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
...
status:
acceptedNames:
kind: TLSCertificateDelegation
listKind: TLSCertificateDelegationList
plural: tlscertificatedelegations
shortNames:
- tlscerts
singular: tlscertificatedelegation
conditions:
- lastTransitionTime: "2021-09-27T15:57:18Z"
message: no conflicts found
reason: NoConflicts
status: "True"
type: NamesAccepted
- lastTransitionTime: "2021-09-27T15:57:19Z"
message: the initial names have been accepted
reason: InitialNamesAccepted
status: "True"
type: Established
```
### Information
- Skaffold version:
- Operating system:
- Installed via:
- Contents of skaffold.yaml:
```yaml
```
### Steps to reproduce the behavior
1. a clonable repository with the sample skaffold project
2. `skaffold `
3. ...
Contributor guide
Assessment
This issue has not been assessed yet.