GoogleContainerTools / GoogleContainerTools/skaffold

Debug level status check logs don't appear on status check nodes

Open
#6,554 0 comments 0 reactions 0 assignees View on GitHub
area/logging area/status-check kind/friction priority/p2 source/partnerships
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Tested using Skaffold from HEAD, and the Bank of Anthos application with debug-level verbosity.

**Actual**
For example, the root `Deploy` task shows:
```
Command output: [Waiting for deployment "loadgenerator" rollout to finish: 0 of 1 updated replicas are available...
]
- pod/loadgenerator-56c646ff69-89gx6: creating container loadgenerator
Running command: [kubectl --context gke_etan-gcp_us-east1-b_gke-dev rollout status deployment loadgenerator --namespace default --watch=false]
Command output: [deployment "loadgenerator" successfully rolled out
]
- pod/loadgenerator-56c646ff69-89gx6: running.
- deployment/loadgenerator is ready.
```

And the `loadgenerator` status check node shows:
```
- deployment/loadgenerator is ready.
```

**Expected**
Some (or all?) of those debug-level logs seem like they belong at the status-check level?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.