GoogleContainerTools / GoogleContainerTools/skaffold

Docker deployer should attempt to reattach to lost containers

Open
#6,281 1 comment 0 reactions 0 assignees View on GitHub
area/deploy deploy/docker kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

From: https://github.com/GoogleContainerTools/skaffold/pull/6265#discussion_r675230138

> it might be confusing UX wise that if a container exits (in my test via os.Exit(1) & docker kill ) skaffold does not give any information to the user, the logs just stop. I think a way to do this would be to open a new ContainerWait and wath for a status change after containers are running:
https://pkg.go.dev/github.com/docker/docker/client?utm_source=godoc#Client.ContainerWait

We should implement a way for Skaffold to attempt to reattach to a lost container, and additionally emit an event and a warning to users that a container has been lost. This should also remove the container from being tracked so Skaffold doesn't try (and fail) to clean it up later.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.