GoogleContainerTools / GoogleContainerTools/skaffold

feat: Support for CustomResource's Image Injection

Open
#5,945 2 comments 1 reaction 0 assignees View on GitHub
area/apply area/env-vars kind/feature-request priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

**Kind**
This is a feature request.

**Background**
As of now, Skaffold only support image injection for Kubernetes kind such as `Deployment`.
I think it will be really valuable to support image injection for `CustomResourceDefinition`. Given a certain `CustomResource` (CR), eg:

```
apiVersion: example.com/v1
kind: MyCustomResource
spec:
template:
spec:
containers:
- name:
```

For each of CR's kind it will be possible for user to define where Skaffold will be able to do the image injection, in this case it'll be on the `IMAGENAME`.

I'm not sure on how this can be done, perhaps we can use the `patch` operation and we define the path where we should perform the image injection alongside the kind where this patch operation should be performed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.