GoogleContainerTools / GoogleContainerTools/skaffold

Support configuring status check independently between modules

Open
#5,746 3 comments 0 reactions 0 assignees View on GitHub
area/config area/modules kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior

For a `skaffold.yaml` containing multiple pipelines, it is valid to configure the `Deploy.StatusCheck` value for each independently.

### Actual behavior

For a `skaffold.yaml` containing multiple pipelines, it is invalid to set the `Deploy.StatusCheck` value to `true` for one pipeline and `false` for another. (See discussion on https://github.com/GoogleContainerTools/skaffold/pull/5706 for details.)

### Information

- Example invalid skaffold.yaml

```yaml
apiVersion: skaffold/v2beta14
kind: Config
build:
artifacts:
- image: skaffold-example
deploy:
kubectl:
manifests:
- k8s-*
statusCheck: true
---
apiVersion: skaffold/v2beta14
kind: Config
build:
artifacts:
- image: skaffold-example
deploy:
kubectl:
manifests:
- k8s-*
statusCheck: false
```

### Steps to reproduce the behavior

1. Run `skaffold dev` using a `skaffold.yaml` similar to the example above.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.