GoogleContainerTools / GoogleContainerTools/skaffold

Instrumentation's online-status should leverage update-check

Open
#5,550 0 comments 0 reactions 0 assignees View on GitHub
area/metrics kind/todo
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

`instrumentation.SetOnlineStatus()` makes a background fetch to see if the user is online. We should leverage the update-check and minimize the number of URL fetches:

https://github.com/GoogleContainerTools/skaffold/blob/9ddcae47b1b00cb7c4134315af7867b4b1abfb74/pkg/skaffold/instrumentation/meter.go#L68

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.