GoogleContainerTools / GoogleContainerTools/skaffold

skaffold find-configs should error if a too-new config file is found

Open
#5,544 0 comments 0 reactions 0 assignees View on GitHub
area/config kind/friction priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

I tried to launch the `examples/helm-deployment` within CC-VSC, which failed in a surprising way. In diagnosing the issue, it turns out that I was actually in `integration/examples/helm-deployment` and the `skaffold.yaml` had too new of an apiVersion. CC uses `skaffold find-configs` to find the configuration files, which in this case returns nothing:
```
$ skaffold version
v1.20.0
$ skaffold find-configs --output json
{}
```

As a result, CC-VSC then tried to do a `skaffold init --analyze`, which failed (due to Helm).

### Expected behavior

`skaffold find-configs` should probably report all `skaffold.yaml` regardless of the apiVersion. It's possible a user is running an older version of Skaffold. Let the version error come up when they attempt to launch.

### Information

- Skaffold version: 1.20.0
- Operating system: macos
- Installed via: Google Cloud SDK
- Contents of skaffold.yaml:
http://github.com/GoogleContainerTools/skaffold/blob/master/integration/examples/helm-deployment/skaffold.yaml

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.