GoogleContainerTools / GoogleContainerTools/skaffold

Moved debug log to Warning with more information on what users can do to get rid of it.

Open
#5,466 0 comments 0 reactions 0 assignees View on GitHub
area/logging bugbash/q4-2022 help wanted kind/usability priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

While debugging #5159, i saw the following log lines in debug mode
```
Tags used in deployment:
- skaffold-example -> skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820
DEBU[0013] push value not present, defaulting to false because cluster.PushImages is false
DEBU[0013] Local images can't be referenced by digest.
They are tagged and referenced by a unique, local only, tag instead.
See https://skaffold.dev/docs/pipeline-stages/taggers/#how-tagging-works

DEBU[0013] getting client config for kubeContext: `kind-kind`
Loading images into kind cluster nodes...
- skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820 -> DEBU[0013] Running command: [kubectl --context kind-kind get nodes -ojsonpath='{@.items[*].status.images[*].names[*]}']
DEBU[0013] Command output: ['....']
DEBU[0013] Running command: [kind load docker-image --name kind skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820]
DEBU[0015] Command output: [], stderr: Image: "skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820" with ID "sha256:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820" not yet present on node "kind-control-plane", loading...
Loaded
Images loaded in 1.704 second
Starting deploy...

```

The below log line sounds like a warning i need to pay attention to. https://skaffold.dev/docs/pipeline-stages/taggers/#how-tagging-works explains the warning to me but no information on what to do to remove this warning.
```
DEBU[0013] Local images can't be referenced by digest.
They are tagged and referenced by a unique, local only, tag instead.
See https://skaffold.dev/docs/pipeline-stages/taggers/#how-tagging-works
```

I propose, we either
1) remove this debug information and say something more explicit
```
DEBU[0013] generating/using tag for skaffold-example:a4ac60aa40be5710a98b1bc7b7de1471e7dee35cd3ba76b87ae1eb95bfca2820 for because local images can't be referenced by digest.
```
2) or remove completely

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.