GoogleContainerTools / GoogleContainerTools/skaffold

Cache should detect locally built image with different name when push fails

Open
#4,818 1 comment 0 reactions 0 assignees View on GitHub
area/build area/cache kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

a common build failure scenario is forgetting to apply a default repo, meaning that images build fine but skaffold will fail because of a failed push. once a default repo is applied, the subsequent build and push will succeed, but rebuilds shouldn't be necessary if the previous build succeeded. however, skaffold's cache check is naive in checking for a direct image name match, and will fail and rebuild, which can be annoying with long image builds.

### Expected behavior
after successful build but failed push, subsequent build/push should detect image built locally if name changes (but tag stays the same)

### Actual behavior
cache check fails because image name has changed

### Information

- Skaffold version: v1.14.0
- Operating system: all

### Steps to reproduce the behavior

1. https://github.com/GoogleCloudPlatform/bank-of-anthos
2. `skaffold build` # build with succeed, but push will fail
3. `skaffold build -d `

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.