GoogleContainerTools / GoogleContainerTools/skaffold

Cannot define patches for properties that have been changed in newer versions

Open
#4,725 4 comments 0 reactions 0 assignees View on GitHub
area/profiles kind/bug priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

From a user report on slack, consider the patch:
```
patches:
- op: add
path: /deploy/helm/releases/0
value:
name: docs
namespace: documentation
chartPath: ./documentation/helm
remote: false
values:
image: docs
```
This is consistent for skaffold API version `skaffold/v1` but in newer versions `value` property of the helm deployer has been renamed to `artifactOverride`. This patch fails to get applied as it's not upgraded to the latest version properly unlike the regular `Pipeline` objects [do](https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/schema/util/upgrade_pipelines.go#L31).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.