GoogleContainerTools / GoogleContainerTools/skaffold

Load images into minikube rather than replacing host's docker env

Open
#4,654 2 comments 1 reaction 0 assignees View on GitHub
area/build help wanted kind/feature-request platform/minikube priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

currently in skaffold, if we detect a user has `minikube` as their active kubecontext, we run a `minikube docker-env` so that `docker` commands on the host machine build to minikube's docker daemon. this can cause issues if we're only trying to run a `skaffold build` while minikube is stopped - something that should be possible, but skaffold can't get around because it only knows to try and use minikube's docker daemon.

instead, we could use `minikube cache add` on images that are built locally, and do this **on push**, so builds will still work even when minikube's docker daemon is not accessible.

https://minikube.sigs.k8s.io/docs/handbook/pushing

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.