GoogleContainerTools / GoogleContainerTools/skaffold
Load images into minikube rather than replacing host's docker env
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
currently in skaffold, if we detect a user has `minikube` as their active kubecontext, we run a `minikube docker-env` so that `docker` commands on the host machine build to minikube's docker daemon. this can cause issues if we're only trying to run a `skaffold build` while minikube is stopped - something that should be possible, but skaffold can't get around because it only knows to try and use minikube's docker daemon.
instead, we could use `minikube cache add` on images that are built locally, and do this **on push**, so builds will still work even when minikube's docker daemon is not accessible.
https://minikube.sigs.k8s.io/docs/handbook/pushing
Contributor guide
Assessment
This issue has not been assessed yet.