GoogleContainerTools / GoogleContainerTools/skaffold

Watcher is sensitive during git transaction

Open
#4,647 3 comments 0 reactions 0 assignees View on GitHub
area/dev kind/bug priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

- My git workflow is based on https://www.git-town.com/
- When I do `git town sync` a couple of stashes and unstashes are done (similar to what `pre-commit` does on unclean repos)
- ... you guessed it! `skaffold dev` is sensitive to such merely chore filesystem changes.
- This eventually gets annoying.

I propose to pause skaffold watcher during a git transaction.

See discussion on `direnv` for similar issue https://github.com/direnv/direnv/issues/653.

Contrary to `direnv`, can we make up a use case where one actually _would_ have a complete rebuild in the midst of a git rebase merge conflict?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.