GoogleContainerTools / GoogleContainerTools/skaffold

Custom builder should be able to return image digest

Open
#4,624 9 comments 0 reactions 0 assignees View on GitHub
area/deploy build/custom kind/bug priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

For customized build, user is responsible for build and publish the image. Skaffold do not need to do the extra validation, or user should be able to disable it. Otherwise, user have to make the extra configuration to allow skaffold to access the image, for example, we need to make the registry public accessible.

### Expected behavior
Skaffold skip the validation for customized build

### Actual behavior
Skaffold is validating the image and extra config is required.
.
### Information

- Contents of skaffold.yaml:

```
apiVersion: skaffold/v2beta4
kind: Config
build:
tagPolicy:
sha256: {}
artifacts:
- image: internal-registry/skaffold-custom
custom:
buildCommand: ./build.sh
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.