GoogleContainerTools / GoogleContainerTools/skaffold

Allow-List of supported k8s kinds should be used only when applying labels

Open
#4,489 9 comments 0 reactions 0 assignees View on GitHub
kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

The `imageReplacer`'s role is to replace image names in k8s yaml by fully qualified names. It does that by visiting the k8s resources, looking for `image` fields and replacing image names that it has a fully qualified name for.

Since #3833, we have an Allow-List that specifies which resource kinds can be transformed and we lost the possibility to replace `image` fields in any random Custom Resource. This was mainly introduced to stop applying labels to resources that had a `metadata` field but didn't support `metadata/labels`.

I think we went to far with that Allow-List and that it **should apply only when we set labels on resources**. (Which by the way we might stop doing)

Another case that we have broken is that we collect namespaces only on resources whose kind is in the Allow-List.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.