GoogleContainerTools / GoogleContainerTools/skaffold

[feature request] json path support wildcard

Open
#4,438 4 comments 3 reactions 0 assignees View on GitHub
area/profiles kind/feature-request priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior
add build arg `REPO_FROM` to all artifact

like

```yaml
patches:
- op: add
path: /build/artifacts[*]/docker/buildArgs
value:
REPO_FROM: 'registry.demo.com/avatar/internal/'
```

### Actual behavior
error

applying profiles: applying profile "development": invalid path: /build/artifacts[*]/docker/buildArgs

### Information

- Skaffold version: version... 5df17d6,
- Operating system: ... macOS 10.14.6
- Contents of skaffold.yaml:

```yaml
apiVersion: skaffold/v2beta4
kind: Config
metadata:
name: erp
build:
local:
push: true
useBuildkit: true
artifacts:
- image: registry.demo.com/avatar/mpaas/shipconsole
context: ../
docker:
dockerfile: avatar/auto/ship/web.Dockerfile
- image: registry.demo.com/avatar/mpaas/shipmobile
context: ../
docker:
dockerfile: avatar/auto/ship/mobile.Dockerfile
- image: registry.demo.com/avatar/mpaas/shipbackground
context: ../
docker:
dockerfile: avatar/auto/ship/background.Dockerfile

profiles:
- name: development
build:
tagPolicy:
dateTime:
format: "dev2006-01-02_15-04-05.999_MST"
timezone: "Local"
patches:
- op: add
path: /build/artifacts[*]/docker/buildArgs
value:
REPO_FROM: 'registry.demo.com/avatar/internal/'

- name: nocache
patches:
- op: add
path: /build/artifacts/0/docker/noCache
value: true

```

### Steps to reproduce the behavior
```bash
skaffold build -p development --build-image=ship
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.