GoogleContainerTools / GoogleContainerTools/skaffold

PVC get deleted on clean up (when bound by a Deployment)

Open
#4,366 15 comments 14 reactions 0 assignees View on GitHub
area/cleanup area/deploy help wanted kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

I've used minio as part of a release in Skaffold (sub-chart). [link](https://github.com/helm/charts/tree/master/stable/minio)

The helm value of the minio: persistence.enabled is set to true, and a PVC is created for its data.
However the PVC get terminated and data is lost when ctrl-c is pressed on Skaffold run.
I don't think Skaffold should ever cleanup and delete PVCs.

I can see Skaffold add a clean up label to it, so probably related:
```
Name: minio
Namespace: default
StorageClass: hostpath
Status: Bound
Volume: pvc-4c8b7fd6-c4b9-4281-8984-91064e6ff1ab
Labels: app=minio
app.kubernetes.io/managed-by=skaffold-v1.11.0
chart=minio-5.0.30
heritage=Helm
release=file-storage
skaffold.dev/builder=local
skaffold.dev/cleanup=true
skaffold.dev/deployer=helm
skaffold.dev/docker-api-version=1.40
skaffold.dev/run-id=1376e569-933e-4669-99e8-42901e3a7e81
skaffold.dev/tag-policy=git-commit
skaffold.dev/tail=true
Annotations: pv.kubernetes.io/bind-completed: yes
pv.kubernetes.io/bound-by-controller: yes
volume.beta.kubernetes.io/storage-provisioner: docker.io/hostpath
Finalizers: [kubernetes.io/pvc-protection]
Capacity: 5Gi
Access Modes: RWO
VolumeMode: Filesystem
Mounted By: minio-678684b4d6-l4dgc
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.