GoogleContainerTools / GoogleContainerTools/skaffold

dev/run should consider exiting instead of warning when built image is not used in deploy.

Open
#3,769 0 comments 0 reactions 0 assignees View on GitHub
area/dev area/run dogfood/helm kind/design discussion kind/feature-request priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

When running skaffold run on a helm example with `Values.image` not set in the `deploy.helm` stanza, we see an error

```
WARN[0050] image [gcr.io/tejal-test/gcr.io/kritis-project/kritis-server:v0.2.2-43-g7e4e3d341-dirty@sha256:9af7dad4992abad490f4ff1ca08b7979fc96230cffbd7aa43baf80ab1a71ce96] is not used.
WARN[0050] image [gcr.io/kritis-project/kritis-server] is used instead.
```
At times, this error is lost is out of display screen due to container logs and users need to scroll up to see the warning.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.