GoogleContainerTools / GoogleContainerTools/skaffold

Skaffold should provide a stopEvent

Open
#3,614 0 comments 0 reactions 0 assignees View on GitHub
area/eventing kind/todo
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

When Skaffold is started, it provides a start-event (though not programmatically identifiable):

```json
{
"result": {
"timestamp": "2020-01-30T16:56:47.256487Z",
"event": {
"metaEvent": {
"entry": "Starting Skaffold: &{Version: ConfigVersion:skaffold/v2alpha3 GitVersion: GitCommit: GitTreeState: BuildDate: GoVersion:go1.13.4 Compiler:gc Platform:darwin/amd64}"
}
}
}
}
```

But there's no explicit tear-down event. It would be useful for any clients to differentiate between the socket being dropped for some reason (unlikely as it is) vs Skaffold being stopped.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.