GoogleContainerTools / GoogleContainerTools/skaffold

Image replacement for more/any fields in CRDs?

Open
#10,142 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

I want skaffold to be able to replace the `image` field in restate.dev/v1beta1/RestateDeployment CRD, just like it does for Deployments and Knative services. Can I do it would changing skaffold code? If not, I think it would be nice to impl this flexibility so that skaffold could support more/any fields in more/any CRDs when user needs.

FYI, my RestateDeployment CR is like

```yaml
apiVersion: restate.dev/v1beta1
kind: RestateDeployment
metadata:
name: my-restate-deployment
spec:
restate:
register:
cluster: restate-test
deploymentMode: knative
knative: {}
template:
spec:
containers:
- image: my-restate-deployment
ports:
- name: h2c
containerPort: 8080
```

Contributor guide

Open the contributing guide

Research direction

The issue names no file, test, or entry point. Start by tracing Skaffold's existing image replacement behavior for Deployments and Knative services, then compare it with the supplied RestateDeployment CRD; done means the requested image field can be replaced for this CRD without breaking existing support.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.