GoogleContainerTools / GoogleContainerTools/jib

Upgrade to newer spring boot version in test suite

Open
#3,877 0 comments 0 reactions 1 assignee Claimed by @emmileaf View on GitHub
area/jib-gradle-plugin enhancement priority:p3
Dominant language
Java
Stars
14.5k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

The current `spring-boot-gradle-plugin` version (2.2.11.RELEASE) used in the unit test suite is pretty old. Suppressed the major version bump in dependabot #3876, but we should try manually upgrading to a newer 2.x version. I think this was previously blocked on the gradle build version, which has been updated since.

Currently the [unit tests](https://github.com/GoogleContainerTools/jib/blob/master/jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/JibPluginTest.java) cover different conditions from #2284 to address `jar` and `bootJar` task output location conflicts. As of Spring Boot 2.5.0, the [packaging default behaviors](https://docs.spring.io/spring-boot/docs/2.5.0/gradle-plugin/reference/htmlsingle/#packaging-executable.and-plain-archives) for jar and war tasks have changed. Will also need to look into this change as part of the manual upgrade.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.