GoogleContainerTools / GoogleContainerTools/jib

Substitute ContainerBuildPlan for ContainerConfiguration and JibContainerBuilder.layerConfigurations

Open
#2,625 0 comments 0 reactions 0 assignees View on GitHub
area/jib-core cleanup priority: p4
Dominant language
Java
Stars
14.5k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

As mentioned in [JibContainerBuilder](https://github.com/GoogleContainerTools/jib/blob/26b5ff1440877458cb3a24a7c7b3799ce0bfa48c/jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java#L77-L82).
```java
private final ContainerBuildPlan.Builder containerBuildPlanBuilder = ContainerBuildPlan.builder();
// TODO(chanseok): remove and use containerBuildPlanBuilder instead. Note that
// ContainerConfiguation implements equals() and hashCode(), so need to verify
// if they are required.
private final ContainerConfiguration.Builder containerConfigurationBuilder =
ContainerConfiguration.builder();
```

The two classes are basically identical. As of now, `JibContainerBuilder` is using both (i.e., duplicating configuration in each class): `ContainerConfiguration` for internal and historical use with the jib-core backend code, and `ContainerBuildPlan` for public API.

`layerConfigurations` can be removed too.
```
// TODO(chanseok): remove and use containerBuildPlanBuilder instead.
private List layerConfigurations = new ArrayList<>();
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.