GoogleCloudPlatform / GoogleCloudPlatform/woolaroo-language-learning-app

Update Guidance on use of Terraform

Open
#166 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
46
Forks
14
PR merge metrics
No merged PRs in 30d

Description

In the [readme](https://github.com/GoogleCloudPlatform/woolaroo-language-learning-app/blob/feature/multilanguage/README.md#google-cloud-project) instructions it is stated to **_download_** the account credentials for Terraform. However this maybe restricted, depending on Google Cloud Org policies that are enforced. Also, in general this shouldn't be the first go to method of authentication.

I suggest the wording is changed. You can actually use your own credentials via `gcloud auth application-default login` or use Cloud Shell (which does the same thing under the hood I believe). Ultimately, this should be an infra CI pipeline where Cloud Build actually does the `terraform apply`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.