GoogleCloudPlatform / GoogleCloudPlatform/training-data-analyst

dqn test miss variable and is broken

Open
#944 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
8.6k
Forks
6.1k
Avg merge
4h 44m
Merged PRs (30d)
2

Description

The unit tests defined for the dqn example is missing `MEMORY_BATCH_SIZE`. However, even after I defined it to say 1 or 2 it still fails.

https://github.com/GoogleCloudPlatform/training-data-analyst/blob/master/quests/rl/dqn/trainer/model_test.py

it fails at
```
self.agent.learn()
```
with:
```
ValueError: Error when checking input: expected frames to have shape (4,) but got array with shape (2,)
```

Thanks a lot by the way for these great modules and for great [intro to RL course in trading specialization on Coursera!](https://www.coursera.org/learn/trading-strategies-reinforcement-learning/home/welcome) This issue may be more relevant to @danideter

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.