GoogleCloudPlatform / GoogleCloudPlatform/training-data-analyst

NodeJS14 is no longer supported by Google Cloud Functions

Open
#2,751 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
8.6k
Forks
6.1k
Avg merge
4h 44m
Merged PRs (30d)
2

Description

In [nodejs cloudendpoints lab prepare_environment.sh](https://github.com/GoogleCloudPlatform/training-data-analyst/blob/master/courses/developingapps/v1.3/nodejs/cloudendpoints/start/prepare_environment.sh), you deploy nodejs14, which is no longer supported. If you update to the below, it will automatically choose the oldest supported version.
```bash
NODEJS_VERSION=$(gcloud functions runtimes list --region us-central1 --filter nodejs | head -n2 | awk ' { print $1 } ')
gcloud functions deploy process-feedback --gen2 --runtime $NODEJS_VERSION --region us-central1 --trigger-topic feedback --source ./function --stage-bucket $GCLOUD_BUCKET --entry-point subscribe --allow-unauthenticated
```
Also, google-p12-pem is no longer maintained, but I don't know which dependency is using it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.