GoogleCloudPlatform / GoogleCloudPlatform/training-data-analyst
Wrong app name in canary deployment
- Dominant language
- Jupyter Notebook
- Stars
- 8.6k
- Forks
- 6.1k
- Avg merge
- 4h 44m
- Merged PRs (30d)
- 2
Description
I'm soffy if posting to wrong place.
In Canary deployments at
https://www.qwiklabs.com/focuses/639?locale=en&parent=catalog
, they say
``` deployments/hello-canary.yaml
app: hello
```
and
> You can verify the `hello` version being served by the request:
>
> ```curl -ks https://`kubectl get svc frontend -o=jsonpath="{.status.loadBalancer.ingress[0].ip}"`/version```
> Run this several times and you should see that some of the requests are served by hello 1.0.0 and a small subset (1/4 = 25%) are served by 2.0.0.
.
But in the file
https://github.com/GoogleCloudPlatform/training-data-analyst/blob/master/courses/ak8s/kubernetes/deployments/hello-canary.yaml
, it's changed to `app: hello-canary`. So ver. 2.0.0 answer never cannot be seen. I've fix that problem.
Checked with below config:
``` deployments/hello-canary.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
name: hello-canary
spec:
replicas: 1
selector:
matchLabels:
app: hello
template:
metadata:
labels:
app: hello
track: canary
version: 2.0.0
...
```
Contributor guide
Assessment
This issue has not been assessed yet.