GoogleCloudPlatform / GoogleCloudPlatform/training-data-analyst

Nodejs upgrade is appengine demo

Open
#1,155 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
8.6k
Forks
6.1k
Avg merge
4h 44m
Merged PRs (30d)
2

Description

https://github.com/GoogleCloudPlatform/training-data-analyst/blob/b7dd4b77c3f9f62860f6456407a48a455cb9d97b/courses/developingapps/v1.2/java/appengine/start/prepare_environment.sh#L41

Please update the nodejs to latest version

Current line:
gcloud functions deploy process-feedback --runtime nodejs8 --trigger-topic feedback --source ./function --stage-bucket $GCLOUD_BUCKET --entry-point subscribe

Updated line:
gcloud functions deploy process-feedback --runtime nodejs10 --trigger-topic feedback --source ./function --stage-bucket $GCLOUD_BUCKET --entry-point subscribe

While running demo application it is throwing warning saying:
WARNING: The Node.js 8 runtime is deprecated on Cloud Functions. Please migrate to Node.js 10 (--runtime=nodejs10)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.