GoogleCloudPlatform / GoogleCloudPlatform/spring-cloud-gcp

[cloud-gcp-pubsub] Add application config to set setDelayThresholdDuration in the millisecond range

Open
#3,437 0 comments 0 reactions 0 assignees View on GitHub
priority: p3 type: enhancement
Dominant language
Java
Stars
551
Forks
349
Avg merge
1d 13h
Merged PRs (30d)
14

Description

**Is your feature request related to a problem? Please describe.**
I want to set `spring.cloud.gcp.pubsub.publisher.batching.delay-threshold-seconds` in the millisecond range.
Currently I have a manual (code) configuration that sets the publisher using `setDelayThresholdDuration` to 100ms. I would like to configure this using the application config. But this is currently impossible as it only accepts 'whole' seconds.

**Describe the solution you'd like**
Add an config option to directly set `setDelayThresholdDuration` in duration form.

**Describe alternatives you've considered**
- Add an option to set `spring.cloud.gcp.pubsub.publisher.batching.delay-threshold-seconds` but for milliseconds
- Add an an "free" option setting field.

Contributor guide

Open the contributing guide

Research direction

Start by tracing the application property spring.cloud.gcp.pubsub.publisher.batching.delay-threshold-seconds to the publisher configuration and the setDelayThresholdDuration call. The change is done when application configuration can express the delay in milliseconds or another duration form, with the existing seconds behavior preserved and covered by the relevant configuration tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, java, spring
Domain
backend, cloud
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.