GoogleCloudPlatform / GoogleCloudPlatform/spring-cloud-gcp

Provide trace instrumentation for Cloud SQL

Open
#3,025 1 comment 3 reactions 0 assignees View on GitHub
priority: p3 type: enhancement
Dominant language
Java
Stars
551
Forks
349
Avg merge
1d 13h
Merged PRs (30d)
14

Description

**Is your feature request related to a problem? Please describe.**
Cloud SQL offers traces and a way of [connecting them to existing traces by using SQL comments](https://cloud.google.com/sql/docs/postgres/using-query-insights#adding-tags-to-sql-queries). There is currently no way of doing this that works for any Java libraries except for Hibernate.

**Describe the solution you'd like**
Integration trace instrumentation support into spring-cloud-gcp Cloud SQL so this works out of the box. Just like this is being offered for [Pub/Sub](https://googlecloudplatform.github.io/spring-cloud-gcp/5.4.3/reference/html/index.html#pubsub-trace-instrumentation-experimental). Applying this on the datasource layer could provide a universal solution.

**Describe alternatives you've considered**
We've looked at [sqlcommenter](https://google.github.io/sqlcommenter/) but this only works for Hibernate.

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the Cloud SQL datasource layer and the existing Pub/Sub trace instrumentation described in the linked reference. Define the datasource-level integration so SQL comments connect Cloud SQL queries to existing traces, and verify that it works for Java libraries beyond Hibernate.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, cloud, databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.