GoogleCloudPlatform / GoogleCloudPlatform/spanner-migration-tool

Feature request - Correct cleanup command to store and use migration project id from metadata db

Open
#808 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PLpgSQL
Stars
155
Forks
83
Avg merge
3d 7h
Merged PRs (30d)
6

Description

Support for separate migration project id and spanner project id was added in this [PR](https://github.com/GoogleCloudPlatform/spanner-migration-tool/pull/802)

In the above PR, for cleanup, migration project id is directly taken from gcloud config. The proper implementation would be to store the migration project id in the metadata DB while initiating the migration. and then use the stored migration project id to cleanup the migration resources.

Pending tasks:
- metadata db schema changes to store migration project id
- Changes to store migration project id.
- Changes in cleanup command to use the migration project id from the metadata db.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.