GoogleCloudPlatform / GoogleCloudPlatform/spanner-migration-tool

Web UI fails to parse password with equals symbol on Migrate

Open
#643 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PLpgSQL
Stars
155
Forks
83
Avg merge
3d 7h
Merged PRs (30d)
6

Description

## Expected Behavior
When clicking `Migrate` on the final page, SMT should start the migration.

## Actual Behavior
When clicking `Migrate` on the final page, SMT throws an error, displaying sensitive info in plaintext:
```
Can't get source and target profiles: error while preparing prerequisites for migration: could not parse source-profile, error =
invalid key=value pair (expected format: key1 =value1):
password=this=isvalid
```
smt-web-pw-parse-error

## Steps to Reproduce the Problem

1. Create a PostgreSQL user with appropriate SMT permissions that has an equals `=` symbol in its password (e.g. `this=isvalid`)
1. Use that user during the initial `Connect to Database` screen
1. Go through the migration steps to the last page (doesn't matter if it's a POC or Low Downtime Migration)
1. Click `Migrate`

## Specifications

- Version: v3.1.1
- Platform:
```
# Server running SMT
> uname -a
Linux 4.19.0-18-cloud-amd64 #1 SMP Debian 4.19.208-1 (2021-09-29) x86_64 GNU/Linux

> go version
go version go1.21.0 linux/amd64

# Browser
Chrome Version 117.0.5938.92 (Official Build) (x86_64) on MacOS 13.5.2
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.