GoogleCloudPlatform / GoogleCloudPlatform/samples-style-guide

Proposal: Language version updates

Open
#98 2 comments 1 reaction 0 assignees View on GitHub
guideline: needs work type: feature request
Dominant language
HTML
Stars
13
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Thank you for taking the time to advocate for samples practice improvements!

### Description

It is unclear to contributors what language version should be supported. I think we should consider the following guidelines:

* Do not update the minimum language version beyond the oldest supported language version. For specific products that support an older version (such as Serverless Runtimes), an older minimum could be considered.
* Do not update the minimum language version to a non-LTS language version, for languages where there is a specific LTS release.

The guideline should also link to per-language official guidance on version support, such as

This proposal is not suggesting adding minimum version indicators or enforcement where not present already.

### Impact

This will create an improved contributor experience, reducing the amount of revisiting the logic.

### Challenge

Negligible, this is mostly about communicating expectations and does not affect code structure.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.