GoogleCloudPlatform / GoogleCloudPlatform/python-docs-samples
[tests] Firestore: add asserts into snippets tests
Open
api: firestore
samples
testing
type: cleanup
- Dominant language
- Jupyter Notebook
- Stars
- 8.1k
- Forks
- 6.7k
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 16
Description
It was noticed that most of the [snippet tests](https://github.com/q-logic/python-docs-samples/blob/f5f3744438e468b4f71cd4524e9f2f1cf7811826/firestore/cloud-client/snippets_test.py) in Firestore doesn't do any asserts.
As per [comments](https://github.com/GoogleCloudPlatform/python-docs-samples/pull/4196#discussion_r451797229) it should be fixed.
/cc @tmatsuo, @busunkim96
Contributor guide
Assessment
This issue has not been assessed yet.