GoogleCloudPlatform / GoogleCloudPlatform/python-docs-samples

[generative_ai] Missed regressions in the code samples because of targeted test runs

Open
#12,990 1 comment 0 reactions 1 assignee Assigned to @msampathkumar View on GitHub
api: vertex-ai samples triage me type: bug
Dominant language
Jupyter Notebook
Stars
8.1k
Forks
6.7k
Avg merge
4d 2h
Merged PRs (30d)
16

Description

## Describe the issue

We're starting to miss regressions in the code samples for `generative_ai` because of migrating the CI to do targeted (per feature directory) test runs. Meaning, when there are no modifications done in a feature directory, the tests will not run in this directory and the issue will silently live there, potentially for a long time.

We need to run the entire test suite regularly to ensure all code samples remain functional.

## Examples

1. [function_calling/basic_example.py](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/function_calling/basic_example.py#L42) is not working anymore with Gemini Flash model. I discovered this when updated a different sample in this directory (see [the comment](https://github.com/GoogleCloudPlatform/python-docs-samples/pull/12811/files#r1866272343)).
2. Two function calling with OpenAI samples — [function_calling/chat_function_calling_basic.py](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/generative_ai/function_calling/chat_function_calling_basic.py) & [function_calling/chat_function_calling_config.py](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/generative_ai/function_calling/chat_function_calling_config.py) — are not working anymore. Same story here: I discovered the issue only because I updated a different file in this feature directory. See [this comment](https://github.com/GoogleCloudPlatform/python-docs-samples/pull/12811/files#r1866447860).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.