GoogleCloudPlatform / GoogleCloudPlatform/pubsub

Load test framework doesn't use pagination when calling instanceGroupManagers.listManagedInstances

Open
#336 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
270
Forks
156
PR merge metrics
No merged PRs in 30d

Description

https://github.com/GoogleCloudPlatform/pubsub/blob/dced135b8f410df2437f428c934020ebbb00d1f9/load-test-framework/src/main/java/com/google/pubsub/flic/controllers/resource_controllers/GCEComputeResourceController.java#L240-L264

By default, instanceGroupManagers.listManagedInstances returns 500 results. If someone were to run the load test framework with publisher workers + subscriber workers > 500, then it's possible for the load test to start without all GCE instances ready to run (there's probably other issues as well).

This is probably not a big deal unless users are trying to run very expensive load tests with this framework.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.