GoogleCloudPlatform / GoogleCloudPlatform/pubsub

PubSub Sink Task Flush issues with clearing partition tracking.

Open
#307 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
270
Forks
156
PR merge metrics
No merged PRs in 30d

Description

The current behavior will throw after reaching the first exception and only clears that partition in the finally block. This results in subsequent partitions not being cleared of tracking and potentially just throwing in the subsequent commit calls.

It also clears tracking for all partitions even if they are not in the list of partitions to flush.

#306 should fix these two issues.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.