GoogleCloudPlatform / GoogleCloudPlatform/pubsec-declarative-toolkit

Make VPC Flow logs optional - for FinOps

Open
#572 0 comments 0 reactions 1 assignee Claimed by @fmichaelobrien View on GitHub
automation deploy developer-experience
Dominant language
Shell
Stars
36
Forks
26
PR merge metrics
No merged PRs in 30d

Description

make the following VPC flow logs optional when creating the VPC subnet

https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/docs/landing-zone-v2/README.md#option-2---project-in-a-folder
```
--enable-flow-logs --logging-aggregation-interval=interval-5-sec --logging-flow-sampling=1.0 --logging-metadata=include-all
```
and
https://github.com/ssc-spc-ccoe-cei/gcp-tools/blob/main/scripts/bootstrap/setup-kcc.sh#L90
```
--enable-flow-logs --logging-aggregation-interval=interval-5-sec --logging-flow-sampling=1.0 --logging-metadata=include-all
```
see
https://github.com/ssc-spc-ccoe-cei/gcp-tools/issues/60
removing in
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/gh446-hub/solutions/setup.sh
for
#446

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.