GoogleCloudPlatform / GoogleCloudPlatform/pubsec-declarative-toolkit
#230 - PR review spawned work items
- Dominant language
- Shell
- Stars
- 36
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230#discussion_r1055640742
[lucstjean-ssc](https://github.com/lucstjean-ssc) reviewed [3 weeks ago](https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230#pullrequestreview-1227937754)
[solutions/landing-zone-v2/README.md](https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230/files/ee3fb445b9c4e94be172bf29c67f72745318fbb8#diff-8d88a2b851dd41ed7676d242a0a1c80293506d330155ea1e456c165b4a674c29)
external: "${BILLING_ACCOUNT_ID?}" # kpt-set: ${billing-id}
This will cause the project to spin up with no attached billing id and any service that requires billing to be enabled will pause deployment until billing is enabled. Billing can be added by a user with Billing User permission in the Billing UI. If you do not remove this section the project will fail to create.
Collaborator
@[lucstjean-ssc](https://github.com/lucstjean-ssc) lucstjean-ssc 3 weeks ago
I don't know what the word remove refers to in the last sentence.
If you do not remove this section the project will fail to create.
Maybe it's meant to be If you do not complete this section the project will fail to create.?
Collaborator
Author
@[davelanglois-ssc](https://github.com/davelanglois-ssc) davelanglois-ssc 2 days ago
@fmichaelobrien @cartyc could you guys revise this section. I copied it from landing-zone v1 but never had the chance to test a deployment with kpt.
## 7 day retention period same as for CSR
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230#discussion_r1056735717
[...ons/gatekeeper-policies/guardrails/09-network-security-services/tests/cloudstorage-test.yaml](https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230/files/ee3fb445b9c4e94be172bf29c67f72745318fbb8#diff-d292a5cee425bbbf19594b9b028d41600b36aa50ddd3b14cfbb4144027b2d4d6)
- action:
type: Delete
condition:
age: 7
Contributor
@[obriensystems](https://github.com/obriensystems) obriensystems [3 weeks ago](https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230#discussion_r1056735717)
I need to verify why the specific delete enablement is set at 7 days - since lz1
Collaborator
Author
@[davelanglois-ssc](https://github.com/davelanglois-ssc) davelanglois-ssc [2 days ago](https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/230#discussion_r1065789224)
Hi @fmichaelobrien , this content was basically copied from the original solution (guardrails-policies). I believe we will want to retire that original solution eventually and just maintain this new version.
let me know if you have additional questions or please "resolve conversation"
Contributor guide
Assessment
This issue has not been assessed yet.