GoogleCloudPlatform / GoogleCloudPlatform/prometheus-engine

Remove our yaml hacks by switching to goccy/go-yaml lib.

Open
#1,629 7 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
232
Forks
109
Avg merge
1d 3h
Merged PRs (30d)
27

Description

Recently we have trouble customizing marshalling of 3rd party structs like:

* Prometheus omitzero problem that cause us to copy structs which is hard to sustain https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1555#issue-2955046159
* Alertmanager secret redaction hacks https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1562

I think we coud replace those frictions by replacing gopkg.in/yaml with https://github.com/goccy/go-yaml?tab=readme-ov-file#features

Another reason for this work is that [`gopkg.in/yaml.*` project seems to be deprecated](https://github.com/go-yaml/yaml?tab=readme-ov-file#this-project-is-unmaintained).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.