GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

Add extra sample date mapping to oracle sample allow list files

Open
#978 2 comments 0 reactions 1 assignee Claimed by @calra123 View on GitHub
good first issue priority: p3
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

Oracle DATE is a date/time therefore it is expected to be mapped to PostgreSQL `timestamp` or BigQuery `datetime`.

We should add the following extra sample mappings.

samples/allow_list/oracle_to_bigquery.yaml

```
# Oracle DATE is a date/time and valid in DATETIME.
"date": "timestamp"
"!date": "!timestamp"
```

samples/allow_list/oracle_to_postgres.yaml

```
# Oracle DATE is a date/time and valid in TIMESTAMP WITHOUT TIME ZONE.
"date": "timestamp"
"!date": "!timestamp"
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.