GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

Oracle unit tests skipped in ci

Open Beginner friendly
#1,821 0 comments 0 reactions 0 assignees View on GitHub
type: testing
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

The tests defined in `tests/unit/ibis_oracle/test_init.py` all have the following decorator:

```python
@pytest.mark.skipif(not get_module_under_test(), reason="No Oracle driver")
```

We do not include `oracledb` package in Nox config:

```python
UNIT_PACKAGES = [
"pyfakefs",
"freezegun",
"teradatasql",
"snowflake-connector-python",
"snowflake-sqlalchemy",
]
```

Therefore the tests are skipped:

```bash
$ pytest tests/unit/ibis_oracle/test_init.py
...
tests/unit/ibis_oracle/test_init.py ssssss [100%]

====================================================================================== 6 skipped in 1.93s
```

Contributor guide

Open the contributing guide

Research direction

Start with tests/unit/ibis_oracle/test_init.py and the Nox configuration containing UNIT_PACKAGES. Run pytest tests/unit/ibis_oracle/test_init.py to confirm the current skips, then inspect how get_module_under_test() detects the Oracle driver. Done means the Oracle unit tests run in the configured environment instead of being skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.