GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator
SQL Server tests use dbo.entries table
- Dominant language
- Python
- Stars
- 524
- Forks
- 171
- Avg merge
- 5d 15h
- Merged PRs (30d)
- 4
Description
In test `test_sql_server_count`, `test_sql_server_row`, `test_schema_validation` we use a hardcoded test table of `dbo.entries`.
This table is not referenced in `sqlserver_test_tables.sql` and should not be hardcoded in `dbo`.
We need to either:
1. Remove the tests because we have better tests for schema, row, column validation, or
2. Add DDL for entries to `sqlserver_test_tables.sql` and change the schema name to `pso_data_validator`.
Contributor guide
Research direction
Start with test_sql_server_count, test_sql_server_row, and test_schema_validation, then inspect sqlserver_test_tables.sql to compare the referenced tables. Determine whether these tests duplicate the existing schema, row, and column validation coverage. Done means either removing the redundant tests or adding the entries DDL and using the pso_data_validator schema consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sql
- Domain
- databases, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100