GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

Tech debt: IfNull rewrite is in wrong module

Open
#1,728 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

I noticed that the lines below in `third_party/ibis/ibis_impala/api.py` effect more than just Impala:

```
@rewrites(ops.IfNull)
def _if_null(op):
return ops.Coalesce((op.arg, op.ifnull_expr))
```

If I comment out the lines then MySQL generated SQL changes too.

We need to review whether we should move this code to `operations.py` or remove it and add engine specific rewrites where they are needed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.