GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

BigQuery test refinement

Open
#1,712 0 comments 0 reactions 0 assignees View on GitHub
priority: p3 type: testing
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

In `data_sources/test_bigquery.py` we set:

```
os.environ[consts.ENV_DIRECTORY_VAR] = f"gs://{TEST_BUCKET}/integration_tests/"
```

I imagine the intention was that this takes effect only for specific tests in this module but it ends up affecting all tests. We should look into refining this so the environment change is only in effect where intended.

This is not currently doing any harm so is low priority.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.