GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

Random row filtering is inefficient

Open
#1,667 3 comments 0 reactions 0 assignees View on GitHub
type: feature request
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

**Is your feature request related to a problem? Please describe.**
Our current random row validation is slow because it orders by `rand()` and then limits by the batch size.
For a 100 million row table is would order all 100 million rows and then throw most of them away.

It would be better to use native sampling on systems that support it (e.g. Oracle).

**What version of DVT are you using?**
8.5.0

**Describe the solution you'd like**
An optimized query that uses native sampling.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.