GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

SQL Server money and smallmoney are incorrectly identified as integral

Open
#1,582 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

**Describe the bug**
SQL Server money and smallmoney are incorrectly identified as integral.

Example output below from a SQL Server to PostgreSQL schema validation:
```
├──────────┼──────────┼───────────┼──────────┼────────────────────────────────────┼────────────────────────────────────┼──────────────────────┼──────────────────────┼─────────────────────┼────────────────────┼─────────────────────┤
│ 3df2c89d │ Schema │ Schema │ [] │ pso_data_validator.dvt_ss2pg_types │ pso_data_validator.dvt_ss2pg_types │ col_money │ col_money │ int64 │ decimal(19, 4) │ fail │
├──────────┼──────────┼───────────┼──────────┼────────────────────────────────────┼────────────────────────────────────┼──────────────────────┼──────────────────────┼─────────────────────┼────────────────────┼─────────────────────┤
│ 3df2c89d │ Schema │ Schema │ [] │ pso_data_validator.dvt_ss2pg_types │ pso_data_validator.dvt_ss2pg_types │ col_smallmoney │ col_smallmoney │ int32 │ decimal(10, 4) │ fail │
├──────────┼──────────┼───────────┼──────────┼────────────────────────────────────┼────────────────────────────────────┼──────────────────────┼──────────────────────┼─────────────────────┼────────────────────┼─────────────────────┤
```

This also effects other validation types. Search for "issue-1582" in `test_sql_server.py` for tests.

**What version of DVT are you using?**
8.1.0

**What type of connections are you using for source and target?**
SQL Server/PostgreSQL

**Screenshots**
If applicable, add screenshots to help explain your problem.

**How are you executing DVT?**
Ex: CLI commands on local computer or VM, within a DAG, Cloud Run job, etc

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.