GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

DVT silently ignores --max-concat-columns when using --comparison-fields

Open
#1,546 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

**Describe the bug**
The max-concat-columns option is only meant for --hash and --concat options during Row Validation. When presented with this option while using --comparison-fields, DVT quietly ignores the option

**What version of DVT are you using?**
7.7.0

**What type of connections are you using for source and target?**
Ex: Postgres 15 for source, Teradata for target

**Steps to reproduce the behavior**
Try `data-validation validate -dr custom-query row -sc postgres -tc postgres -sq 'select * from pso_data_validator.dvt_many_cols' -tq 'select * from pso_data_validator.dvt_many_cols' -pk=id -comp-fields='*' -mcc 200`

**Expected behavior**
Print a warning saying this option does not apply wwith --comparison-fields.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.