GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

Comparison fields validation of large decimal fails on PostgreSQL

Open
#1,454 0 comments 0 reactions 1 assignee Claimed by @renzokuken View on GitHub
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

You can enable the column `col_num_38` in test `test_row_validation_comp_fields_oracle_to_postgres` to reproduce the problem.

In column validation we cast column that will overflow int64/float64 to string in the engine before we let Ibis/Pandas coerce them to float thereby making them lossy. I suggest we do the same for comparison fields.

This issue was found during internal testing and is not affecting a customer.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.