GoogleCloudPlatform / GoogleCloudPlatform/professional-services-data-validator

DVT connection configurations are file based and require multiple secret manager entries to keep them secure

Open
#1,074 1 comment 0 reactions 0 assignees View on GitHub
priority: p1
Dominant language
Python
Stars
524
Forks
171
Avg merge
5d 15h
Merged PRs (30d)
4

Description

Hi,

DVT's usage of secret manager poses two issues:

1. DVT stores connection configurations in a file. This means that when we create a container image, we need to bake in the connections into the image.
2. DVT stores the secret manager information and the name of the secrets in the connections configuration. Each configuration parameter (host, port, username, password) has to be its own secret. This is difficult to use.

A better approach would be to store the entire connection configuration as a JSON object in the secret manager. Every command that uses a connection will need to be updated to provide an option to access the connection configuration from the secret manager rather than the filesystem.

Sundar Mudupalli

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.